Review Request 115296: Do not set CMAKE_REQUIRED_DEFINES
Alex Merry
kde at randomguy3.me.uk
Mon Jan 27 12:05:59 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115296/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 12:05 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kde4support
Description
-------
Do not set CMAKE_REQUIRED_DEFINES
The variable _KDE4_PLATFORM_DEFINITIONS is no longer set by
KDEFrameworkCompilerSettings.cmake / KDECompilerSettings.cmake, but
CMAKE_REQUIRED_DEFINES is set properly by it.
Diffs
-----
src/ConfigureChecks.cmake 7c8951f685f57f771b1cee5758dab0e87e614bf7
Diff: https://git.reviewboard.kde.org/r/115296/diff/
Testing
-------
Compiles fine, while it didn't before. Feature tests seem to be producing sensible results.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/a0ae13f1/attachment.html>
More information about the Kde-frameworks-devel
mailing list