Review Request 115295: Do not set CMAKE_REQUIRED_DEFINES

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115295/#review48336
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Jan. 24, 2014, 2:45 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115295/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 2:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjs
> 
> 
> Description
> -------
> 
> Do not set CMAKE_REQUIRED_DEFINES
> 
> The variable _KDE4_PLATFORM_DEFINITIONS is no longer set by
> KDEFrameworkCompilerSettings.cmake / KDECompilerSettings.cmake, but
> CMAKE_REQUIRED_DEFINES is set properly by it.
> 
> 
> Diffs
> -----
> 
>   src/kjs/ConfigureChecks.cmake 94de6e71f750bdd62b512c680e5d767c1f0e199b 
> 
> Diff: https://git.reviewboard.kde.org/r/115295/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine (although it did before).  Feature tests seem to be producing sensible results.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/a18d6c90/attachment.html>