Review Request 114997: Improve KAuth README.md

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jan 27 02:18:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114997/#review48325
-----------------------------------------------------------



README.md
<https://git.reviewboard.kde.org/r/114997/#comment34187>

    Need to use? link against?
    
    Also the "(or similar)" looks unsure. I would say:
    If you are using cmake, you can find KAuth by using:
    find_package(KF5Auth NO_MODULE)
    
    or finding KF5 with the Auth component, from your CMake scripts.


- Aleix Pol Gonzalez


On Jan. 26, 2014, 5:39 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114997/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2014, 5:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Dario Freddi.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> Improve KAuth README.md
> 
> 
> Diffs
> -----
> 
>   README.md a8a011a147d2dcc0fb5db39e263412005a86def4 
> 
> Diff: https://git.reviewboard.kde.org/r/114997/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/dc2fcfba/attachment.html>


More information about the Kde-frameworks-devel mailing list