Review Request 115028: Allow the building of deprecated code to be disabled

[Alex Merry]

Bump; does anyone have any comments on this idea?

Alex



On 15/01/14 13:56, Alex Merry wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> 
> 
> Review request for KDE Frameworks.
> By Alex Merry.
> *Repository: * kcoreaddons
> 
> 
>   Description
> 
> This is mostly an example of how we could improve the deprecation handling.  There are two parts: preventing deprecation warnings when building the library itself (see http://build.kde.org/view/Frameworks/job/kwidgetsaddons_master_qt5/11/warnings17Result/NORMAL/package.-1402078525/ for examples) and allowing the framework to be built with no deprecated code.
> 
> We possibly want to export the fact that the framework was built without deprecated code via the CMake config file, so that downstream stuff (like kde4support) can check for it and complain if necessary.
> 
> 
> Allow the building of deprecated code to be disabled
> 
> This adds a CMake option to enable or disable the building of deprected
> code.  It just changes the kcoreaddons_export.h file.
> 
> Part of this change is to use KCOREADDONS_NO_DEPRECATED instead of
> KDE_NO_DEPRECATED.
> 
> Disable deprecation macro when building the library itself
> 
> This prevents spurious compiler warnings (particularly when slots are
> deprecated).
> 
> 
>   Diffs
> 
>   * src/lib/CMakeLists.txt (8cc71f34e671962f2d7268b3db0d50e6750c26a2)
>   * src/lib/util/kuser.h (2b6e6ed92bc1465945f36f2fde821f36fa51585f)
>   * src/lib/util/kuser_unix.cpp (8a3a39d379ca863b4906bb01228c5e01a5b955b0)
>   * src/lib/util/kuser_win.cpp (6a6cbb1751bd569d8684f8e11add1ef304c0a94d)
> 
> View Diff <https://git.reviewboard.kde.org/r/115028/diff/>
> 
> 
> 
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>