Review Request 115300: Fix KKeySequence shortcut types flags
David Faure
faure at kde.org
Sat Jan 25 09:01:52 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115300/#review48258
-----------------------------------------------------------
Ship it!
Hehe, nice find. The bug is in KDE 4.x too, but fixing it would be BIC, so yeah.
- David Faure
On Jan. 24, 2014, 4:13 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115300/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 4:13 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> I assume the code was /trying/ to default to checking against local and global shortcuts, in practice it was only ever going to select local shortcuts.
>
>
> Diffs
> -----
>
> src/kkeysequencewidget.cpp cc9016b
> src/kkeysequencewidget.h d5d70ea
>
> Diff: https://git.reviewboard.kde.org/r/115300/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140125/84bd5bbd/attachment.html>
More information about the Kde-frameworks-devel
mailing list