Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

[Alexander Richardson]

> On Jan. 24, 2014, 2:04 p.m., Alex Merry wrote:
> > CMakeLists.txt, line 47
> > <https://git.reviewboard.kde.org/r/115289/diff/1/?file=235831#file235831line47>
> >
> >     Oh, also, should this be something like (WIN32) or (WIN32 AND NOT CYGWIN)?
> >     
> >     (Is WIN32 defined under CYGWIN?)

I just tested this, apparently under cygwin cmake defines UNIX and CYGWIN but not WIN32


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/#review48204
-----------------------------------------------------------


On Jan. 24, 2014, 1:35 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115289/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 1:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> MSVC fix: Check for libintl.h and libintl.lib
> 
> On MSVC we have libintl as a separate library and must therefore explicitly
> link to it. This is not required on linux since gettext is part of glibc.
> On Windows libintl.h is not always found in the default include path and
> has to be searched for.
> 
> Fix linking on MSVC by using KTRANSCRIPT_EXPORT
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 
>   src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
>   src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
>   src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
>   src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
> 
> Diff: https://git.reviewboard.kde.org/r/115289/diff/
> 
> 
> Testing
> -------
> 
> Compiles on Windows, no change to Linux
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140124/b5d72a9a/attachment.html>