Review Request 115268: Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115268/#review48223
-----------------------------------------------------------


Looks good to me.
Once this is committed I will try to make sure it also handles MSVC _HAS_EXCEPTIONS=0 or 1 to enable/disable exceptions in the STL (http://stackoverflow.com/questions/553103/can-i-disable-exceptions-in-stl). If we don't set this to 0 by default we get tons of warnings because the STL headers use try/catch.

- Alexander Richardson


On Jan. 23, 2014, 7:18 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115268/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 7:18 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions
> 
> kde_enable_exceptions() essentially does what
> set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}  ${KDE_ENABLE_EXCEPTIONS}")
> used to do.  kde_target_enable_exceptions does it on a per-target basis.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake 7891136124ced0273ff05bbe521d93acc22a00f7 
> 
> Diff: https://git.reviewboard.kde.org/r/115268/diff/
> 
> 
> Testing
> -------
> 
> Both macros tested with ThreadWeaver (compilation and tests).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140124/928c8ab7/attachment.html>