Review Request 115296: Do not set CMAKE_REQUIRED_DEFINES

Alex Merry kde at randomguy3.me.uk
Fri Jan 24 14:45:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115296/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kde4support


Description
-------

Do not set CMAKE_REQUIRED_DEFINES

The variable _KDE4_PLATFORM_DEFINITIONS is no longer set by
KDEFrameworkCompilerSettings.cmake / KDECompilerSettings.cmake, but
CMAKE_REQUIRED_DEFINES is set properly by it.


Diffs
-----

  src/ConfigureChecks.cmake 7c8951f685f57f771b1cee5758dab0e87e614bf7 

Diff: https://git.reviewboard.kde.org/r/115296/diff/


Testing
-------

Compiles fine, while it didn't before.  Feature tests seem to be producing sensible results.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140124/318c4944/attachment.html>


More information about the Kde-frameworks-devel mailing list