Build failed in Jenkins: kde4support_master_qt5 #32

[Christoph Cullmann]

Hmm, see

https://git.reviewboard.kde.org/r/115292/

that fixes it for me ;)

----- Ursprüngliche Mail -----
> On 24/01/14 13:30, Alex Merry wrote:
> > On 24/01/14 13:22, Christoph Cullmann wrote:
> >>> I recreated my build directories and now I'm hitting it too. I guess it a
> >>> matter of time that it spreads to the rest of who are building
> >>> kde4support...
> >>>
> >>> I tried with cmake 2.8.12.1 and today's master.
> >> It seems to be this change:
> >>
> >> https://projects.kde.org/projects/kdesupport/extra-cmake-modules/repository/revisions/8b055d7f229d6596cf15d045b85ec937f8e2abe8
> >>
> >> Could it be, that now, as we use add_definitions in that file before the
> >> C/CXX FLAGS are
> >> set again, we loose these defines?
> > 
> > If it does, that's a bug in CMake, as we only ever append to
> > CMAKE_CXX_FLAGS.
> 
> Ah, found the issue.  The problem *was* with that commit, but the issue
> was that we no longer define _KDE4_PLATFORM_DEFINITIONS, and
> kde4support/src/ConfigureChecks.cmake has, on line 20,
> 
> set(CMAKE_REQUIRED_DEFINITIONS ${_KDE4_PLATFORM_DEFINITIONS})
> 
> Alex
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> 

-- 
----------------------------- Dr.-Ing. Christoph Cullmann ---------
AbsInt Angewandte Informatik GmbH      Email: cullmann at AbsInt.com
Science Park 1                         Tel:   +49-681-38360-22
66123 Saarbrücken                      Fax:   +49-681-38360-20
GERMANY                                WWW:   http://www.AbsInt.com
--------------------------------------------------------------------
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234