Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/#review48203
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/115289/#comment34102>

    It would be better to have this functionality in a FindLibintl.cmake in the cmake/ directory.



CMakeLists.txt
<https://git.reviewboard.kde.org/r/115289/#comment34103>

    "since it is not part of libc" (the whole point is it is not glibc at all, right?)



src/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115289/#comment34104>

    No need for a conditional here.  target_link_libraries is fine being passed empty arguments.  In fact, I would get rid of the quotes as well.


- Alex Merry


On Jan. 24, 2014, 12:35 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115289/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 12:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> MSVC fix: Check for libintl.h and libintl.lib
> 
> On MSVC we have libintl as a separate library and must therefore explicitly
> link to it. This is not required on linux since gettext is part of glibc.
> On Windows libintl.h is not always found in the default include path and
> has to be searched for.
> 
> Fix linking on MSVC by using KTRANSCRIPT_EXPORT
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 
>   src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
>   src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
>   src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
>   src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
> 
> Diff: https://git.reviewboard.kde.org/r/115289/diff/
> 
> 
> Testing
> -------
> 
> Compiles on Windows, no change to Linux
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140124/be0c774c/attachment-0001.html>