Review Request 115259: Simplify the project directories that are searched for images etc

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115259/#review48116
-----------------------------------------------------------

Ship it!


Thanks for this. It's much simpler this way. Just a little nitpick with the inner function. Feel free to commit when this is fixed.


src/kapidox/__init__.py
<https://git.reviewboard.kde.org/r/115259/#comment34043>

    Having a function definition in the middle of another function is a bit surprising. I would move it at the start of the function.


- Aurélien Gâteau


On Jan. 23, 2014, 3:10 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115259/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 3:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> Simplify the project directories that are searched for images etc
> 
> Files will be found under various docs/ subdirs (and docs/api is not
> considered any more).
> 
> 
> Diffs
> -----
> 
>   README.md c1fe269a424366ec50ba18a31b71c28d96df2869 
>   src/kapidox/__init__.py e6ffda63f96780c2ae71717054c097be6fec04bb 
> 
> Diff: https://git.reviewboard.kde.org/r/115259/diff/
> 
> 
> Testing
> -------
> 
> Ran kgenapidox on kbookmarks with python2 and python3.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140123/425e7250/attachment.html>