Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

Luigi Toscano luigi.toscano at tiscali.it
Wed Jan 22 21:59:33 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115237/#review48082
-----------------------------------------------------------

Ship it!


As I wrote in the original review request, fine with me (other opinions are welcome of course!)

- Luigi Toscano


On Jan. 22, 2014, 9:28 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115237/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 9:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> Moving it from KDocTools, as discussed in Review Request 115077. Defined as a forward to the new command KDOCTOOLS_CREATE_HANDBOOK. Notice that the description of the command changed to document the actual name of the target created.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/KDE4Macros.cmake a3894ae 
> 
> Diff: https://git.reviewboard.kde.org/r/115237/diff/
> 
> 
> Testing
> -------
> 
> Tried using this on a Kig build for frameworks. The warning message is displayed and the doc-handbook target is created for folder doc.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140122/1ca94b7a/attachment.html>


More information about the Kde-frameworks-devel mailing list