Review Request 115218: rename dbus interface file on install for kwallet
Valentin Rusu
kde at rusu.info
Wed Jan 22 21:27:20 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115218/#review48079
-----------------------------------------------------------
src/api/KWallet/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115218/#comment34033>
The interface will be strictly the same. New features will be added to secret service. That's why I didn't consider changing it's name. And, btw, changing it's name will make users think that changes have been (or will be) done to this API.
- Valentin Rusu
On Jan. 22, 2014, 11:23 a.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115218/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 11:23 a.m.)
>
>
> Review request for KDE Frameworks and Valentin Rusu.
>
>
> Repository: kwallet-framework
>
>
> Description
> -------
>
> Rename kwallet dbus interface file on install so it does not clash with equivalent file from kdelibs4. The dbus interface remains the same to keep compatibility with kdelibs4 kwallet.
>
> However you seem to have renamed the interface in places in the code in runtime/, will it be incompatible with the version from kdelibs4?
>
>
> Diffs
> -----
>
> src/api/KWallet/CMakeLists.txt d0d5a3d
>
> Diff: https://git.reviewboard.kde.org/r/115218/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140122/53680d11/attachment.html>
More information about the Kde-frameworks-devel
mailing list