Review Request 115212: Fix windows build + 1 compiler warning

[Alex Merry]

> On Jan. 22, 2014, 4:28 p.m., Alex Merry wrote:
> > src/kgesture.cpp, lines 382-385
> > <https://git.reviewboard.kde.org/r/115212/diff/2/?file=235218#file235218line382>
> >
> >     This should probably have a comment, or some helpful person will come along and change it back :-)

Actually, I withdraw my "ship it".  I have been (quite rightly) berated for letting you get away with the description "it breaks MSVC somehow".

Feel free to commit the rest of the stuff in this review, but this needs more information at the very least (what problem does it cause?  error messages?).


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115212/#review48056
-----------------------------------------------------------


On Jan. 22, 2014, 2:49 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115212/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 2:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> 4 separate  commits: 
> 
> 
> 1. Fix windows build with QT_NO_CAST_FROM_ASCII
> 
> 
> 2. m_collator already returs bool, remove check for < 0
> 
> 
> 3. Don't use foreach for this loop, it somehow breaks MSVC
> 
> 
> 4. Don't use uname() and getpwuid() directly
> 
> Added new functions that also do the right thing on Windows
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4516a9ee3da774788c76f30f15181fa0049a9d86 
>   src/kbugreport.cpp 56f088106becbccca5e9731abc04118a19e36ba9 
>   src/kgesture.cpp 49c927803b2e16806985d758103d3e359aa58dd4 
>   src/kkeysequencewidget.cpp cc9016b776c16984b83a36a2742526ede624bf5e 
>   src/ksendbugmail/CMakeLists.txt 12b4926ecddeb023315f6074ab57cfe6cdee65ff 
>   src/ksendbugmail/main.cpp 8f85f315f0746bb774175114b1e284e899957fd3 
>   src/ksendbugmail/smtp.cpp 90b6b98467b0c220cfef18bc35cf3c07df9a8cf3 
>   src/kshortcutseditoritem.cpp 086f833fc505f69a3b0dbe6fceffdb94ecd60330 
>   src/systeminformation_p.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115212/diff/
> 
> 
> Testing
> -------
> 
> now it compiles on windows and Linux is still fine
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140122/0596e211/attachment-0001.html>