Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

[Alexander Richardson]

> On Jan. 22, 2014, 9:22 a.m., Patrick von Reth wrote:
> > Until now we had no problems with the data installed to bin/../share  and this setup would make it impossible to have multiple independent  kde setups on one system.
> 
> Alexander Richardson wrote:
>     I know. The problem is QStandardPaths with QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I think %APPDATA%. KF5 based KDE software won't work otherwise since it can't find the data. I think the better way of fixing this is patching Qt, but for now this works.
> 
> Patrick Spendrin wrote:
>     Can you keep that patch locally for now and we try and come up with a patch for Qt instead? We cannot restrict ourselves at that point I think.
> 
> Alexander Richardson wrote:
>     Sure no problem. I'll drop this request
> 
> David Faure wrote:
>     So what do you recommend instead, for QStandardPaths? Checking some non-standard environment variable? or?

I would go for the environment variable. Something like QSTANDARDPATHS_EXTRA_DATA_DIRS that is checked in addition to the default dirs.

Would also be useful for other cases: e.g. in the okteta unit tests I set XDG_DATA_DIRS so that my test data gets found by QStandardPaths (I know there is QFINDTESTDATA, but that won't work in that case).

It would also be nice if there were some cross-platform solution like QStandardpaths::addDirectory(QStandardPaths::StandardLocation, const QString& path) to inject (like KStandardDirs::addResourceDir).


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115210/#review47983
-----------------------------------------------------------


On Jan. 22, 2014, 3:53 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115210/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 3:53 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and kdewin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows
> 
> Otherwise QStandardPaths will always fail with e.g. GenericDataLocation
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 
> 
> Diff: https://git.reviewboard.kde.org/r/115210/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140122/85df5300/attachment.html>