Review Request 115211: Mark target created by ecm_add_test as non GUI by default
Alex Merry
kde at randomguy3.me.uk
Wed Jan 22 12:08:31 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115211/#review48009
-----------------------------------------------------------
Ship it!
This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets).
- Alex Merry
On Jan. 22, 2014, 1:28 a.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115211/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 1:28 a.m.)
>
>
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Mark target created by ecm_add_test as non GUI by default
>
> This behaviour can be overriden by passing the GUI flag to the command
>
>
> Diffs
> -----
>
> modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e
>
> Diff: https://git.reviewboard.kde.org/r/115211/diff/
>
>
> Testing
> -------
>
> Oketeta unit tests wouldn't build on windows before this commit, now they do
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140122/c61eafe8/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list