Review Request 115212: Fix windows build + 1 compiler warning

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115212/#review47991
-----------------------------------------------------------



src/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115212/#comment33998>

    I would move this further up the file and add it to XMLGUI_EXTRA_LIBS



src/kbugreport.cpp
<https://git.reviewboard.kde.org/r/115212/#comment33999>

    You appear to no longer set d->os...



src/kshortcutseditoritem.cpp
<https://git.reviewboard.kde.org/r/115212/#comment34000>

    True, but operator() is undocumented anyway.  I would replace it with
    m_collator.compare(..., ...) < 0



src/systeminformation_p.h
<https://git.reviewboard.kde.org/r/115212/#comment34001>

    This seems like it belongs in conditionally-compiled source files (systeminformation_win.cpp and systeminformation_unix.cpp?).  I'm not *that* fussed about this, though, since it's a fairly short file.



src/systeminformation_p.h
<https://git.reviewboard.kde.org/r/115212/#comment34002>

    Ditch the trailing spaces if you're not going to deal with service packs.


- Alex Merry


On Jan. 22, 2014, 1:41 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115212/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 1:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> 4 separate  commits: 
> 
> 
> 1. Fix windows build with QT_NO_CAST_FROM_ASCII
> 
> 
> 2. m_collator already returs bool, remove check for < 0
> 
> 
> 3. Don't use foreach for this loop, it somehow breaks MSVC
> 
> 
> 4. Don't use uname() and getpwuid() directly
> 
> Added new functions that also do the right thing on Windows
> 
> 
> Diffs
> -----
> 
>   src/systeminformation_p.h PRE-CREATION 
>   src/kbugreport.cpp 56f088106becbccca5e9731abc04118a19e36ba9 
>   src/CMakeLists.txt 4516a9ee3da774788c76f30f15181fa0049a9d86 
>   src/kgesture.cpp 49c927803b2e16806985d758103d3e359aa58dd4 
>   src/kkeysequencewidget.cpp cc9016b776c16984b83a36a2742526ede624bf5e 
>   src/ksendbugmail/CMakeLists.txt 12b4926ecddeb023315f6074ab57cfe6cdee65ff 
>   src/ksendbugmail/main.cpp 8f85f315f0746bb774175114b1e284e899957fd3 
>   src/ksendbugmail/smtp.cpp 90b6b98467b0c220cfef18bc35cf3c07df9a8cf3 
>   src/kshortcutseditoritem.cpp 086f833fc505f69a3b0dbe6fceffdb94ecd60330 
> 
> Diff: https://git.reviewboard.kde.org/r/115212/diff/
> 
> 
> Testing
> -------
> 
> now it compiles on windows and Linux is still fine
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140122/b6b2fe6f/attachment-0001.html>