Review Request 115198: Fix KDE4Support compilation
David Faure
faure at kde.org
Wed Jan 22 08:25:57 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115198/#review47984
-----------------------------------------------------------
Indeed - thanks for the notification of breakage. I committed a more complete fix, though.
- David Faure
On Jan. 21, 2014, 10:23 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115198/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 10:23 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kde4support
>
>
> Description
> -------
>
> KCrash::setApplicationName and KCrash::setApplicationPath disappeared from the KCrash module 179de6d16fb9be580dbb7b15e0a56fcb990c7516, so I guess that a good fix is just stop using it.
>
> I'm unsure what's the best way though.
>
>
> Diffs
> -----
>
> src/kdeui/kapplication.cpp 5a7f4c8
>
> Diff: https://git.reviewboard.kde.org/r/115198/diff/
>
>
> Testing
> -------
>
> Builds.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140122/59255441/attachment.html>
More information about the Kde-frameworks-devel
mailing list