Review Request 115199: Fix detection of shared-mime-info on Windows
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Jan 21 23:32:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/#review47959
-----------------------------------------------------------
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On Jan. 21, 2014, 11:30 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115199/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 11:30 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Fix detection of shared-mime-info on Windows
>
> For some reason exec_program would fail, it works with execute_process
>
>
> Diffs
> -----
>
> cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232
>
> Diff: https://git.reviewboard.kde.org/r/115199/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/485f14a7/attachment.html>
More information about the Kde-frameworks-devel
mailing list