Review Request 115199: Fix detection of shared-mime-info on Windows

Alex Merry kde at randomguy3.me.uk
Tue Jan 21 23:19:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115199/#review47957
-----------------------------------------------------------



cmake/FindSharedMimeInfo.cmake
<https://git.reviewboard.kde.org/r/115199/#comment33953>

    On Unix, `update-mime-database -v` outputs to stderr.  You should set ERROR_VARIABLE to the same values as OUTPUT_VARIABLE (this will merge the streams); that way it should work on both Windows and Unix.


- Alex Merry


On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115199/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 10:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Fix detection of shared-mime-info on Windows
> 
> For some reason exec_program would fail, it works with execute_process
> 
> 
> Diffs
> -----
> 
>   cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 
> 
> Diff: https://git.reviewboard.kde.org/r/115199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/cc3ef159/attachment.html>


More information about the Kde-frameworks-devel mailing list