Review Request 115202: Allow building KConfigWidgets on Windows

[Alexander Richardson]

> On Jan. 21, 2014, 11:29 p.m., Luigi Toscano wrote:
> > Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated?
> 
> Alexander Richardson wrote:
>     two separate commits, however kdoctools is broken on windows so I made it optional to allow building
> 
> Luigi Toscano wrote:
>     Wouldn't it be better to fix KDocTools on windows instead? :)
>     
>     What is broken? Is it the issue with compiling libxml/libxslt?

The problem is that it can't find kdex.dtd. I guess I could fix that by copying it the right location, but thats more of a hack.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115202/#review47936
-----------------------------------------------------------


On Jan. 21, 2014, 11:26 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115202/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 11:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> Make KDocTools an optional dependency
> 
> 
> Fix compilation on MSVC
> 
> Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d 
>   src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 
> 
> Diff: https://git.reviewboard.kde.org/r/115202/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/84a3e424/attachment.html>