Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)
Alex Merry
kde at randomguy3.me.uk
Tue Jan 21 22:41:37 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114980/#review47942
-----------------------------------------------------------
Welp, since no-one seems to care, I'm gonna commit it.
- Alex Merry
On Jan. 12, 2014, 12:58 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114980/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2014, 12:58 p.m.)
>
>
> Review request for KDE Frameworks and Alex Merry.
>
>
> Repository: kdesignerplugin
>
>
> Description
> -------
>
> Do not explicity find or use Qt5WebKit(Widgets)
>
> The kdewebkit designer plugin does not directly use anything from
> Qt5WebKitWidgets, only KWebView from KF5WebKit. Qt5WebKitWidgets is
> found as a dependency of KF5WebKit. So we do not need to find it
> ourselves, or explicitly link against it.
>
>
> Diffs
> -----
>
> CMakeLists.txt d13d071f935306df2d052b58a6a03ea92bba36f3
> src/CMakeLists.txt 55ac819d4c2cbaac483cec9617402e18fbe22d2b
>
> Diff: https://git.reviewboard.kde.org/r/114980/diff/
>
>
> Testing
> -------
>
> Still configures, builds and installs.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/c4b31d90/attachment.html>
More information about the Kde-frameworks-devel
mailing list