Review Request 115201: Use qplatformdefs.h

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115201/#review47940
-----------------------------------------------------------

Ship it!


Looks good, still compiles fine here (Linux, gcc).


src/kbookmark.h
<https://git.reviewboard.kde.org/r/115201/#comment33947>

    I wondered if this was going to make a comeback...


- Alex Merry


On Jan. 21, 2014, 10:22 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115201/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 10:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kbookmarks
> 
> 
> Description
> -------
> 
> Use qplatformdefs.h
> 
> 
> Add a dummy qHash function so that MSVC doesn't fail
> 
> 
> Diffs
> -----
> 
>   src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a 
>   src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 
>   src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 
>   src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 
> 
> Diff: https://git.reviewboard.kde.org/r/115201/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/99bdf4a3/attachment.html>