Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

[David Faure]

> On Jan. 21, 2014, 2:57 p.m., David Faure wrote:
> > Note that I fixed the "build failure with kdesrc-build" differently - I added a "ignore-modules kapidox" in kdesrc-build's include files.
> > 
> > And I don't like that this will break when using a custom prefix and PYTHONPATH is not set (which is the case here).
> >
> 
> Alex Merry wrote:
>     You can't really avoid that with Python packages; you can install them with --user and make sure your PATH is set correctly, or you can install them with a prefix and make sure your PYTHONPATH is set correctly (or there are a couple of other ways of telling python about custom site package dirs).
>     
>     Well, or you can install them in a standard location, such as for distro packages.
> 
> Aurélien Gâteau wrote:
>     Note that the breakage is at runtime, not install time. But since kdesrc-build now ignores kapidox, maybe it's simpler to discard this patch? That's one less piece to maintain.
> 
> Alex Merry wrote:
>     Sure; I have no opinion on it either way, TBH.

Ah right, it won't break make install. Then I withdraw my objection, go ahead.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115166/#review47881
-----------------------------------------------------------


On Jan. 21, 2014, 1:49 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115166/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 1:49 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py.
> 
> 
> Diffs
> -----
> 
>   README.md 660e9c3 
>   CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115166/diff/
> 
> 
> Testing
> -------
> 
> Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/432b235d/attachment.html>