Review Request 114897: Make KDE_ENABLE_EXCEPTIONS a list

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114897/
-----------------------------------------------------------

(Updated Jan. 21, 2014, 6:14 p.m.)


Status
------

This change has been discarded.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Stephen Kelly.


Repository: extra-cmake-modules


Description
-------

Make KDE_ENABLE_EXCEPTIONS a list

When KDE_ENABLE_EXCEPTIONS contains two arguments, they are currently a
single string containing those space-separated arguments.  It can thus
be used as
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${KDE_ENABLE_EXCEPTIONS}")
However, the proper way to set compile flags these days is to use
add_compile_options, as in
add_compile_options(${KDE_ENABLE_EXCEPTIONS})
which requires KDE_ENABLE_EXCEPTIONS to be a list.

Note that this change means that setting CMAKE_CXX_FLAGS like above NO
LONGER WORKS (as you will get the argument
-fexceptions;-UQT_NO_EXCEPTIONS added for GCC and Clang).


Diffs
-----

  kde-modules/KDECompilerSettings.cmake cd93e519dea4917a6c09df02bb32254f468c2861 

Diff: https://git.reviewboard.kde.org/r/114897/diff/


Testing
-------

ThreadWeaver compiles under GCC on Linux if (and only if) I change the src/CMakeLists.txt file to use add_compile_options instead of setting CMAKE_CXX_FLAGS.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/545b7d7b/attachment.html>