Review Request 115078: don't install dbus interface files in kglobalaccel

Martin Gräßlin mgraesslin at kde.org
Tue Jan 21 15:23:13 UTC 2014



> On Jan. 21, 2014, 4:16 p.m., Martin Gräßlin wrote:
> > something went wrong with the latest patch. CMake looks fine but it includes the renamed files.
> 
> Jonathan Riddell wrote:
>     Maybe I'm going mad but I don't see any renamed files in it.  Here's the same patch in a pastebin
>     http://paste.ubuntu.com/6792111/

I blame review board. It showed me the new CMakeLists.txt but still the renamed files... Now it works.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47884
-----------------------------------------------------------


On Jan. 21, 2014, 4:10 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/c9e9c7f9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list