Review Request 115078: don't install dbus interface files in kglobalaccel

Martin Gräßlin mgraesslin at kde.org
Tue Jan 21 14:55:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47879
-----------------------------------------------------------


I like this approach better (though I don't know whether that's causing problems on the DBus side). Maybe we could keep the files as they are and just rename at install?

- Martin Gräßlin


On Jan. 21, 2014, 3:49 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 3:49 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -----
> 
>   src/org.kde.kglobalaccel.Component.xml ec21201 
>   src/org.kde.KGlobalAccel.xml 8746551 
>   src/kf5_org.kde.kglobalaccel.Component.xml PRE-CREATION 
>   src/kf5_org.kde.KGlobalAccel.xml PRE-CREATION 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/f9e27b09/attachment.html>


More information about the Kde-frameworks-devel mailing list