Review Request 115078: don't install dbus interface files in kglobalaccel

[Jonathan Riddell]

> On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote:
> > this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream.
> 
> Hrvoje Senjan wrote:
>     What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing...
>     (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-)
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     I think the idea is to move the xml file to kde-workspace somehow?
> 
> Jonathan Riddell wrote:
>     @Gräßlin How would it break the workflow?  You can install kdelibs4 and kf5 anywhere you like and it'll still compile fine.  But it won't overlap files if they are installed to the same place with these changes.
>     
>     @sandsmark yes the files would be moved into kde-workspace, see patch in https://git.reviewboard.kde.org/r/115079/
> 
> Martin Gräßlin wrote:
>     How is a setup going to find the xml file to generate an interface from if it doesn't get installed? A true KF5 setup shouldn't pick anything from kdelibs4. By not installing it, things depending on it will be broken. Or am I missing something?
> 
> Martin Gräßlin wrote:
>     Oh and I think review request https://git.reviewboard.kde.org/r/115079/ illustrates the problem. As the file doesn't get installed any more, we need to copy it everywhere where it's going to be used. This looks like a very sub-optimal solution.

The xml file would be included in the kde-workspace source directly ( https://git.reviewboard.kde.org/r/115079/ )


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47614
-----------------------------------------------------------


On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 4:07 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -----
> 
>   KF5GlobalAccelConfig.cmake.in 5f069d3 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/528ae96d/attachment-0001.html>