Review Request 115078: don't install dbus interface files in kglobalaccel

Jonathan Riddell jr at jriddell.org
Tue Jan 21 12:51:09 UTC 2014



> On Jan. 17, 2014, 5:39 p.m., Thomas Lübking wrote:
> > and what if kdelibs (really, not kde-runtime?) from SC4 is not installed? KF/5 would be broken then, would it not?
> > What about having a common data package downstream?

No it wouldn't be broken, it would continue to compile using the .xml files it has locally.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47587
-----------------------------------------------------------


On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 4:07 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -----
> 
>   KF5GlobalAccelConfig.cmake.in 5f069d3 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/30166d15/attachment.html>


More information about the Kde-frameworks-devel mailing list