QStringLiteral and QTimer in KCompletion tests

[David Gil Oliva]

Hi!

*kcompletionuitest.cpp*

In kcompletionuitest.cpp I have found many uses of QStringLiteral that
perhaps aren't necessary, but I'm not sure:

Form1::Form1(QWidget *parent)
    : QWidget(parent)
{
    setAttribute(Qt::WA_DeleteOnClose);
    *setObjectName(QStringLiteral("Form1"));*
    resize(559, 465);
    *setWindowTitle(QStringLiteral("Form1"));*
    Form1Layout = new QVBoxLayout(this);

    GroupBox1 = new QGroupBox(this);
    GroupBox1->setLayout(new QVBoxLayout());
    *GroupBox1->setTitle(QStringLiteral("Completion Test"));*

Can't it be just GroupBox1->setTitle("Completion Test"); for example?

*kcomboboxtest.cpp*

Another thing: the test kcomboboxtest has a Enable/Disable button that uses
a QTimer, so, when pressed, it takes 5 endless seconds to enable/disable
the combo boxes and change the text of the button. May I take off that
QTimer or is it useful in some unknown way? :-/


Thanks!

David Gil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140121/5913d7f2/attachment.html>