Review Request 115147: Fix non-X11 implementation of KPassivePopup placement
Martin Gräßlin
mgraesslin at kde.org
Mon Jan 20 14:17:58 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115147/#review47781
-----------------------------------------------------------
src/kpassivepopup.cpp
<https://git.reviewboard.kde.org/r/115147/#comment33875>
why is the QScreen include needed? Looks like the changes don't use it
src/kpassivepopup.cpp
<https://git.reviewboard.kde.org/r/115147/#comment33874>
is this comment still valid? QXcbWindow knows the concept of foreign windows. So maybe the code could just be simplified and the if - else completely removed?
- Martin Gräßlin
On Jan. 20, 2014, 3:03 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115147/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2014, 3:03 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> Fix non-X11 implementation of KPassivePopup placement
>
>
> Diffs
> -----
>
> src/kpassivepopup.cpp b41cb8dc8b3372346bd12c0413bf6bfa9a6fd00d
>
> Diff: https://git.reviewboard.kde.org/r/115147/diff/
>
>
> Testing
> -------
>
> Builds when I comment out find_package(X11) in the CMakeLists.txt file.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140120/1aed462d/attachment.html>
More information about the Kde-frameworks-devel
mailing list