Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
Commit Hook
null at kde.org
Mon Jan 20 10:34:55 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114904/#review47759
-----------------------------------------------------------
This review has been submitted with commit 2748a51aa61f6dbc93827e56d94ac92c9f0889b1 by Alex Merry to branch master.
- Commit Hook
On Jan. 19, 2014, 1:21 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114904/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2014, 1:21 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
>
> This appears to be a hangover from the KDE4 days, which would adjust
> certain paths to match the ones for kdelibs if you installed an
> application to the same prefix as kdelibs. This was probably to make
> KStandardDirs work properly in unusual setups.
>
>
> Diffs
> -----
>
> kde-modules/KDEInstallDirs.cmake 838a52384b7cbfc84c5bd02c2f40f027f36db169
>
> Diff: https://git.reviewboard.kde.org/r/114904/diff/
>
>
> Testing
> -------
>
> CMake runs fine on KCoreAddons (clean build dir), and only the install prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140120/20f37733/attachment.html>
More information about the Kde-frameworks-devel
mailing list