Review Request 115120: Clean up the CMake files (and a couple of other bits)

[Alex Merry]

> On Jan. 19, 2014, 8:07 p.m., David Faure wrote:
> > src/imageformats/CMakeLists.txt, line 53
> > <https://git.reviewboard.kde.org/r/115120/diff/1/?file=234669#file234669line53>
> >
> >     Remind me, who uses these desktop files?
> >     
> >     Only the kde4support code, right?

Yep.  I must get round to submitting that patch to Qt that should allow us to ditch them...


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115120/#review47727
-----------------------------------------------------------


On Jan. 19, 2014, 12:23 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115120/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 12:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> Clean up the CMake files (and a couple of other bits)
> 
> src/imageformats/CMakeLists.txt is now much clearer and more consistent.
> 
> Also, removed an unnecessary/unimplemented method from exr.cpp.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c39d6f322d335fa5d19e934d0f7c5c602ba1a502 
>   cmake/FindOpenEXR.cmake b4ae656722a78e8f3494415e4583709e9b29065e 
>   src/imageformats/CMakeLists.txt 053054a54ef53b7695b244748c3e5c0f252cc8c3 
>   src/imageformats/config-kimgio.h.cmake  
>   src/imageformats/exr.h 3ae9e16e3d6e74240e14ce8994a1d9126c4bdd36 
>   src/imageformats/exr.cpp f8c70b7547781614b05936f893a526d12b4a41b1 
>   src/imageformats/jp2.cpp 5be5063d034b048aa47c5491796a89bc4519d3e4 
> 
> Diff: https://git.reviewboard.kde.org/r/115120/diff/
> 
> 
> Testing
> -------
> 
> Compiles, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140120/575dac18/attachment-0001.html>