Review Request 115078: don't install dbus interface files in kglobalaccel

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Mon Jan 20 01:36:10 UTC 2014



> On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote:
> > this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream.
> 
> Hrvoje Senjan wrote:
>     What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing...
>     (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-)

I think the idea is to move the xml file to kde-workspace somehow? 


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review47614
-----------------------------------------------------------


On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 4:07 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -----
> 
>   KF5GlobalAccelConfig.cmake.in 5f069d3 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140120/cb125ada/attachment.html>


More information about the Kde-frameworks-devel mailing list