Review Request 115123: Add an imported target to FindOpenEXR.cmake

[Alex Merry]

> On Jan. 19, 2014, 5:21 p.m., Stephen Kelly wrote:
> > cmake/FindOpenEXR.cmake, line 26
> > <https://git.reviewboard.kde.org/r/115123/diff/3/?file=234694#file234694line26>
> >
> >     What is in PC_OpenEXR_CFLAGS_OTHER ?
> >     
> >     INTERFACE_COMPILE_DEFINITIONS is only suitable for compile definitions, whereas the compile_definitions() command also accepts other flags.

All preprocessor and compiler flags that are not -I flags.  In practice, it is -pthread.  I'm actually setting INTERFACE_COMPILE_OPTIONS, not INTERFACE_COMPILE_DEFINITIONS, for that reason.

The use of the _DEFINITIONS variable is inherited from the original FindOpenEXR.cmake file.  As far as I can tell, the traditional Find*.cmake approach is to put compile options into PkgName_DEFINITIONS, probably because add_definitions() is liberal about the arguments it accepts.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115123/#review47714
-----------------------------------------------------------


On Jan. 19, 2014, 3:49 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115123/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 3:49 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> Add an imported target to FindOpenEXR.cmake
> 
> This simplifies using the find module.
> 
> 
> Diffs
> -----
> 
>   cmake/FindOpenEXR.cmake b4ae656722a78e8f3494415e4583709e9b29065e 
>   src/imageformats/CMakeLists.txt 053054a54ef53b7695b244748c3e5c0f252cc8c3 
> 
> Diff: https://git.reviewboard.kde.org/r/115123/diff/
> 
> 
> Testing
> -------
> 
> Builds (tested when OpenEXR is found).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140119/b3f3fe75/attachment.html>