Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

[Friedrich W. H. Kossebau]

> On Jan. 18, 2014, 8:58 a.m., David Faure wrote:
> > Why does this remove some forwarding headers?
> 
> Friedrich W. H. Kossebau wrote:
>     Because they are installed from the KParts module itself already, with the same forwarding include path. So no need to duplicate them in KDE4Support, or?
>     
>     (Only difference is those from KParts have '"' around the path, not '<' and '>'. This is a small error in ecm_generate_headers still, it needs to add ../ in front of the path in case of a prefixed path. Other option would be '<' as well '>', but a relative link seems safer to me)
> 
> David Faure wrote:
>     But this is the case for most of the forwarding headers installed by kde4support. They "duplicate" the ones installed by the frameworks.
>     One reason is that the ones from kde4support go into include/KDE, so they make old-style <KDE/KParts/Part> work, and the other reason is historical (we had this before we had ecm_generate_header).

Ah, did not think of people using <KDE/...>, okay (though now I remember there was even a case with one of the fixes I prepared for the other programs). In that case I will also need to fix-up things for my recent commit to  kde4support/src/includes/KNS3, as I removed most CamelCase-forwarding headers with the same (wrong) reasoning. Will update this patch as well in a few minutes.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115098/#review47627
-----------------------------------------------------------


On Jan. 18, 2014, 3:48 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115098/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2014, 3:48 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> Counterpart to: https://git.reviewboard.kde.org/r/115097/
> 
> Main discussion over there, please.
> 
> 
> Diffs
> -----
> 
>   src/includes/KParts/OpenUrlEvent c3e9e59 
>   src/includes/KParts/Part bcb6c5e 
>   src/includes/KParts/PartActivateEvent dabdd2f 
>   src/includes/KParts/PartBase bcb6c5e 
>   src/includes/KParts/PartManager 2dcfeb3 
>   src/includes/KParts/PartSelectEvent dabdd2f 
>   src/includes/KParts/Plugin f73168d 
>   src/includes/KParts/ReadOnlyPart bcb6c5e 
>   src/includes/KParts/ReadWritePart bcb6c5e 
>   src/includes/KParts/StatusBarExtension 8c8a481 
>   src/includes/KParts/TextExtension cb73ab5 
>   src/includes/KParts/WindowArgs c3e9e59 
>   src/kparts/listingextension.h PRE-CREATION 
>   src/CMakeLists.txt 23b0d6d 
>   src/includes/CMakeLists.txt 2b2130f 
>   src/includes/KParts/BrowserExtension c3e9e59 
>   src/includes/KParts/BrowserHostExtension c3e9e59 
>   src/includes/KParts/BrowserInterface 640f47b 
>   src/includes/KParts/BrowserRun b63479b 
>   src/includes/KParts/Event dabdd2f 
>   src/includes/KParts/FileInfoExtension 13c7c41 
>   src/includes/KParts/GUIActivateEvent dabdd2f 
>   src/includes/KParts/HistoryProvider b8c3fc9 
>   src/includes/KParts/HtmlExtension aae280e 
>   src/includes/KParts/ListingExtension 38598f9 
>   src/includes/KParts/LiveConnectExtension c3e9e59 
>   src/includes/KParts/MainWindow 452e115 
> 
> Diff: https://git.reviewboard.kde.org/r/115098/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140119/6ad0ad3c/attachment.html>