Review Request 115123: Add an imported target to FindOpenEXR.cmake

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115123/#review47698
-----------------------------------------------------------


Makes a lot of sense to me, yep.


cmake/FindOpenEXR.cmake
<https://git.reviewboard.kde.org/r/115123/#comment33844>

    I would simply add a fatal_error if cmake version is VERSION_LESS 2.8.12, and remove the rest of this version stuff.


- Stephen Kelly


On Jan. 19, 2014, 1:15 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115123/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 1:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> Stephen - is this a sensible thing to be doing in Find*.cmake files?
> 
> 
> Add an imported target to FindOpenEXR.cmake
> 
> This simplifies using the find module.
> 
> 
> Diffs
> -----
> 
>   cmake/FindOpenEXR.cmake b4ae656722a78e8f3494415e4583709e9b29065e 
>   src/imageformats/CMakeLists.txt 053054a54ef53b7695b244748c3e5c0f252cc8c3 
> 
> Diff: https://git.reviewboard.kde.org/r/115123/diff/
> 
> 
> Testing
> -------
> 
> Builds (tested when OpenEXR is found).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140119/ba6b2502/attachment.html>