Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

[Dominik Haumann]

> On Jan. 18, 2014, 7:46 p.m., Christoph Feck wrote:
> > Hm, how does KMessageWidget behave, if you "post" the next message without waiting for the animation to finish? I somehow feel that the queuing should be done inside KMessageWidget.

KMessageWidget has no post function at all. It is just a widget that displays text and actions. Queuing is what Kate Part builds around it, and that is exactly why these functions the patch adds are required. 


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115101/#review47655
-----------------------------------------------------------


On Jan. 18, 2014, 6:13 p.m., Dominik Haumann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115101/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2014, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and Aurélien Gâteau.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> This patch adds the signal KMessageWidget::hideAnimationFinished(), indicating that the hide animation is finished.
> 
> This is required by Kate Part's passive notification system, since the next pending message is shown only after the hide animation is finished.
> Right now, Kate Part launches a timer of 500ms (these 500 ms are used by kmessagewidget's animatedHide()) to estimate when the animation is finished.
> 
> This signal cannot be replaced by e.g. deriving KMessageWidget, since QHideEvent is also sent in case of the parent widget is hidden.
> 
> The same holds for animatedShow(): Emit signal showAnimationFinished() when the show animation is finished.
> 
> Besides that, the two convenience functions
>     bool hideAnimationRunning() const;
>     bool showAnimationRunning() const;
> are also added to check the current state of the animations. This is also required by Kate Part in order to wait until an animation is finished before starting a new one.
> 
> 
> Diffs
> -----
> 
>   src/kmessagewidget.h a17bccf 
>   src/kmessagewidget.cpp deb82a3 
> 
> Diff: https://git.reviewboard.kde.org/r/115101/diff/
> 
> 
> Testing
> -------
> 
> In Kate Part, not commited so far, though.
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140118/baa5417e/attachment-0001.html>