Review Request 115077: Rename Macros in KF5DocTools to KDE5_

[David Narváez]

> On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote:
> > KF5DocToolsMacros.cmake, lines 166-172
> > <https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166>
> >
> >     These should *not* be renamed, as they are compatibility macros.  However, they should probably be moved to kde4support.
> 
> Aleix Pol Gonzalez wrote:
>     I wouldn't rename it indeed.
>     
>     Moving it to KDE4Support can be good indeed, although it kind of defeats the purpose, as you'll need to actually depend on KDE4Support to get the warning.

Luigi, your call.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115077/#review47592
-----------------------------------------------------------


On Jan. 17, 2014, 3:14 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115077/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 3:14 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Part of the overall task of removing mentions of KDE4 from the code.
> 
> 
> Diffs
> -----
> 
>   KF5DocToolsMacros.cmake 191a2c5 
> 
> Diff: https://git.reviewboard.kde.org/r/115077/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140118/89c16d2c/attachment.html>