Review Request 115024: Remove check for X11

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115024/
-----------------------------------------------------------

(Updated Jan. 18, 2014, 9:40 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Andreas Hartmetz.


Repository: kxmlgui


Description
-------

Remove check for X11

The only thing that was using it was a preprocessor branch in
kkeysequencewidget.cpp, which only had branches for Mac and X11.  It
appears to be intended to control the order of modifiers in a key
sequence description, but there is no explanation anywhere in the logs
for the fact that it checks for X11.


(Added Andreas as the original author of this code back in the transition to KDE 4).

Update: actually, it looks like this originally used KKeyServer to get the modifier descriptions, which was only implemented for X11 and Mac.  So that explains that...


Diffs
-----

  CMakeLists.txt 11a5af110a101a18e4b5a36f1d7e91a34c1b09c5 
  src/CMakeLists.txt 29e7dfe4aa89c03778bf4137840727fb54c1332b 
  src/config-xmlgui.h.cmake bde7885db30843a0cb241d1ee0ac9e22c762d7b3 
  src/kkeysequencewidget.cpp 65ff05eec6b99cdcf7db5505475f11918b76a767 

Diff: https://git.reviewboard.kde.org/r/115024/diff/


Testing
-------

Configure, build, run tests, install.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140118/ef45cc2c/attachment-0001.html>