Review Request 115077: Rename Macros in KF5DocTools to KDE5_

Alex Merry kde at randomguy3.me.uk
Fri Jan 17 18:51:51 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115077/#review47592
-----------------------------------------------------------



KF5DocToolsMacros.cmake
<https://git.reviewboard.kde.org/r/115077/#comment33794>

    These should *not* be renamed, as they are compatibility macros.  However, they should probably be moved to kde4support.


- Alex Merry


On Jan. 17, 2014, 3:14 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115077/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 3:14 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Part of the overall task of removing mentions of KDE4 from the code.
> 
> 
> Diffs
> -----
> 
>   KF5DocToolsMacros.cmake 191a2c5 
> 
> Diff: https://git.reviewboard.kde.org/r/115077/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140117/e4253bcd/attachment.html>


More information about the Kde-frameworks-devel mailing list