Review Request 115050: Declare the correct Qt version in QCA pkg-config file.

[Ivan Romanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115050/#review47541
-----------------------------------------------------------


Patch is good. But only one issue. All Qt version specific code should be placed in if()...else()...endif() blocks
So move set(QCA_QT_PC_VERSION "QtCore") to else(Qt5Core_FOUND).

- Ivan Romanov


On Jan. 16, 2014, 7:04 p.m., Uwe L. Korn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115050/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 7:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Ivan Romanov.
> 
> 
> Repository: qca
> 
> 
> Description
> -------
> 
> Declare the correct Qt version the pkg-config file. Qt4 is called QtCore whereas Qt5 is called Qt5Core. Declaring QtCore when building with Qt5 will either link to Qt4 when both are installed and a project depending on QCA is resolving dependencies via pkg-config or will fail because of missing dependencies if Qt4 is not installed.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 87b0702 
>   qca2.pc.cmake 22004cc 
> 
> Diff: https://git.reviewboard.kde.org/r/115050/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed and used on Gentoo (with Qt5).
> 
> 
> Thanks,
> 
> Uwe L. Korn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140116/e9fe3ea6/attachment.html>