Review Request 115049: Do not require ktranscript to be installed for the test to run

Aurélien Gâteau agateau at kde.org
Thu Jan 16 17:02:42 UTC 2014



> On Jan. 16, 2014, 2:20 p.m., Alex Merry wrote:
> > Ship It!
> 
> Alex Merry wrote:
>     Aurélien: you put the wrong REVIEW: line in.  You'll have to close this manually.

Ohoh, the fail :(


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115049/#review47498
-----------------------------------------------------------


On Jan. 16, 2014, 1:58 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115049/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 1:58 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Bugs: 329994
>     https://bugs.kde.org/show_bug.cgi?id=329994
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Kubuntu packagers had problems running "make test" because the ktranscript test relied on the ktranscript plugin being installed to run. This RR avoids this by loading the plugin from the build dir.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 9e5fa0c 
>   autotests/ktranscripttest.cpp db8139a 
> 
> Diff: https://git.reviewboard.kde.org/r/115049/diff/
> 
> 
> Testing
> -------
> 
> Reverted install dir to a "before KF5" state, installed KJS, built ki18n without installing, ran the test successfully.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140116/39b1a865/attachment.html>


More information about the Kde-frameworks-devel mailing list