Review Request 115030: Install public headers for KJsEmbed

[Aleix Pol Gonzalez]

> On Jan. 16, 2014, 3:48 p.m., Alex Merry wrote:
> > Still not ideal, but -- in the absence of an enthusiastic maintainer -- that's unlikely to change any time soon.  At least this makes it usable, and the names shouldn't clash.

:) that's the spirit!

Anyway, without installing headers, the library is useless.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115030/#review47516
-----------------------------------------------------------


On Jan. 16, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115030/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 2:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjsembed
> 
> 
> Description
> -------
> 
> KJsEmbed library is useless without headers installed. This patch installs them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt fc1731a 
>   src/kjsembed/CMakeLists.txt b4d3f5f 
>   src/kjsembed/kjseglobal.h c2b44dc 
>   src/kjsembed/pointer.h e25a5e4 
> 
> Diff: https://git.reviewboard.kde.org/r/115030/diff/
> 
> 
> Testing
> -------
> 
> I ported the share dataengine to use it (it was using the now defunct Kross KJS support).
> 
> https://git.reviewboard.kde.org/r/115027/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140116/cc20692b/attachment.html>