Review Request 115030: Install public headers for KJsEmbed

Thu Jan 16 14:33:40 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115030/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 2:33 p.m.)

Review request for KDE Frameworks.

Changes
-------

Fixed Alex Merry's concerns.

Removed comments, included a couple of things in the KJSEmbed namespace.

Repository: kjsembed

Description
-------

KJsEmbed library is useless without headers installed. This patch installs them.

Diffs (updated)
-----

  CMakeLists.txt fc1731a 
  src/kjsembed/CMakeLists.txt b4d3f5f 
  src/kjsembed/kjseglobal.h c2b44dc 
  src/kjsembed/pointer.h e25a5e4 

Diff: https://git.reviewboard.kde.org/r/115030/diff/

Testing
-------

I ported the share dataengine to use it (it was using the now defunct Kross KJS support).

https://git.reviewboard.kde.org/r/115027/

Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140116/e8038e87/attachment-0001.html>