Review Request 115030: Install public headers for KJsEmbed

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115030/#review47503
-----------------------------------------------------------



src/kjsembed/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115030/#comment33765>

    These don't look like public headers; are they really needed?
    
    Pointer isn't even namespaced.  And kjseglobal.h has the unnamedspaced RedirectIOToConsole function.



src/kjsembed/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115030/#comment33764>

    This comment should go.


- Alex Merry


On Jan. 15, 2014, 2:26 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115030/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2014, 2:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjsembed
> 
> 
> Description
> -------
> 
> KJsEmbed library is useless without headers installed. This patch installs them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt fc1731a 
>   src/kjsembed/CMakeLists.txt b4d3f5f 
> 
> Diff: https://git.reviewboard.kde.org/r/115030/diff/
> 
> 
> Testing
> -------
> 
> I ported the share dataengine to use it (it was using the now defunct Kross KJS support).
> 
> https://git.reviewboard.kde.org/r/115027/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140116/66da1724/attachment.html>