Review Request 115026: Remove commented out code for QX11EmbedContainer/WhatsThis

Alex Merry kde at randomguy3.me.uk
Thu Jan 16 13:21:43 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115026/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 1:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kxmlgui


Description
-------

Remove commented out code for QX11EmbedContainer/WhatsThis

This appears to be a hangover from the Qt 3 days, and the QXEmbed class.
It never did anything once we moved to Qt 4, and no-one seems to have
noticed.


Diffs
-----

  src/khelpmenu.cpp 9ea91acba8b41e37f0c72dacb9cf4b3d32c2341f 

Diff: https://git.reviewboard.kde.org/r/115026/diff/


Testing
-------

Configure; build; tests; install.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140116/151c5ea3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list