Review Request 115049: Do not require ktranscript to be installed for the test to run

Aurélien Gâteau agateau at kde.org
Thu Jan 16 12:58:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115049/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 1:58 p.m.)


Review request for KDE Frameworks and Chusslove Illich.


Changes
-------

Use target_compile_definitions, as suggested by Alex.


Bugs: 329994
    https://bugs.kde.org/show_bug.cgi?id=329994


Repository: ki18n


Description
-------

Kubuntu packagers had problems running "make test" because the ktranscript test relied on the ktranscript plugin being installed to run. This RR avoids this by loading the plugin from the build dir.


Diffs (updated)
-----

  autotests/CMakeLists.txt 9e5fa0c 
  autotests/ktranscripttest.cpp db8139a 

Diff: https://git.reviewboard.kde.org/r/115049/diff/


Testing
-------

Reverted install dir to a "before KF5" state, installed KJS, built ki18n without installing, ran the test successfully.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140116/de53820d/attachment.html>


More information about the Kde-frameworks-devel mailing list