Review Request 114979: Do not install licenses

Aurélien Gâteau agateau at kde.org
Wed Jan 15 14:45:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114979/#review47453
-----------------------------------------------------------

Ship it!


Makes sense, thanks!

- Aurélien Gâteau


On Jan. 15, 2014, 3:09 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114979/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2014, 3:09 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> Do not install licenses
> 
> Firstly, we should certainly not be installing something as generic as
> standard license texts to a location as generic as share/LICENSES.
> 
> Secondly, it is not our job to install license text at all.  We provide
> licenses with all parts of our source distributions, and it is up to the
> producers of binary distributions to decide on the best way to make
> license text available for those.
> 
> 
> Note that the combination of this and https://git.reviewboard.kde.org/r/114971/ will result in nothing being installed by kapidox at all.  I eventually intend to install the apidox generation scripts themselves, along with the necessary data files.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 02114642f0713e44f581e58c4d47192b4db2d238 
>   licenses/ARTISTIC 8f9bdefc4db9428a02812c0d24c887b0f3d7ef40 
>   licenses/BSD cca2a5c9abb92e2f4d4d2ad7085dcd9f59809bd0 
>   licenses/CMakeLists.txt ffc215b208cd7ebb5318e1283e306d24d396dc0d 
>   licenses/GPL_V2 64a675c0f0e75697595e31e7c3ed75dbbe65e567 
>   licenses/GPL_V3 94a9ed024d3859793618152ea559a168bbcbb5e2 
>   licenses/LGPL_V2 172c288f875590edacca050630b1c99d11eb6385 
>   licenses/LGPL_V3 fc8a5de7edf437cdc98a216370faf7c757279bcb 
>   licenses/QPL_V1.0 85bc6356f50d05096c4b877f8587e361b5fed7c7 
> 
> Diff: https://git.reviewboard.kde.org/r/114979/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140115/449e4c16/attachment.html>


More information about the Kde-frameworks-devel mailing list