Review Request 115016: Make KJob usable from QML
Alex Merry
kde at randomguy3.me.uk
Wed Jan 15 12:47:41 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115016/#review47440
-----------------------------------------------------------
Ship it!
After Kevin Krammer's comment on the list, I realised I'd been misreading the Q_PROPERTY docs. So this is fine, and can go in.
- Alex Merry
On Jan. 14, 2014, 8:16 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115016/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 8:16 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Add a couple of Q_PROPERTY and Q_SCRIPTABLE to KJob, so that it can be consumed elsewhere. The idea isn't to be able to implement KJobs, but to be able to keep track of them from QML and check if it succeeded.
>
>
> Diffs
> -----
>
> src/lib/jobs/kjob.h 24dbaec
>
> Diff: https://git.reviewboard.kde.org/r/115016/diff/
>
>
> Testing
> -------
>
> Everything still builds, shouldn't be a big deal.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140115/f4a34710/attachment.html>
More information about the Kde-frameworks-devel
mailing list